RE: [PATCH 23/32] x86/intel_rdt.c: Extend RDT to per cache and per resources

[Yu, Fenghua]

> From: Thomas Gleixner [mailto:tglx@xxxxxxxxxxxxx]
> Sent: Wednesday, July 13, 2016 6:07 AM
> To: Yu, Fenghua <fenghua.yu@xxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxx>; Anvin, H Peter
> <h.peter.anvin@xxxxxxxxx>; Luck, Tony <tony.luck@xxxxxxxxx>; Tejun Heo
> <tj@xxxxxxxxxx>; Borislav Petkov <bp@xxxxxxx>; Stephane Eranian
> <eranian@xxxxxxxxxx>; Peter Zijlstra <peterz@xxxxxxxxxxxxx>; Marcelo
> Tosatti <mtosatti@xxxxxxxxxx>; David Carrillo-Cisneros
> <davidcc@xxxxxxxxxx>; Shankar, Ravi V <ravi.v.shankar@xxxxxxxxx>; Vikas
> Shivappa <vikas.shivappa@xxxxxxxxxxxxxxx>; Prakhya, Sai Praneeth
> <sai.praneeth.prakhya@xxxxxxxxx>; linux-kernel <linux-
> kernel@xxxxxxxxxxxxxxx>; x86 <x86@xxxxxxxxxx>
> Subject: Re: [PATCH 23/32] x86/intel_rdt.c: Extend RDT to per cache and per
> resources
> 
> On Tue, 12 Jul 2016, Fenghua Yu wrote:
> 
> > From: Fenghua Yu <fenghua.yu@xxxxxxxxx>
> >
> > QoS mask MSRs array is per cache. We need to allocate CLOSID per cache
> > instead global CLOSID.
> >
> > A few different resources can share same QoS mask MSRs array. For
> > example, one L2 cache can share QoS MSRs with its next level
> > L3 cache. A domain number represents the L2 cache, the L3 cache, the
> > L2 cache's shared cpumask, and the L3 cache's shared cpumask.
> >
> > cctable is extended to be index by domain number so that each cache
> > has its own control table.
> >
> > shared_domain is introduced to cover multiple resources sharing
> > CLOSID.
> 
> This patch does a dozen different things at once. Can you please split the
> cleanup parts, the parts where statics are removed and the actual changes in
> the representation model apart so this can be reviewed?
> 
> And while at this, please fold back thes cleanups into the original patches.
> There is no point to have these changes seperate.

Sure. Will do this.

Thanks.

-Fenghua