RE: [PATCH 08/32] Define CONFIG_INTEL_RDT

From: Thomas Gleixner
Date: Wed Jul 13 2016 - 17:12:15 EST


On Wed, 13 Jul 2016, Yu, Fenghua wrote:
> Here is why this patch behaves like this:
>
> This patch and actually first 12 patches are directly from last year's
> cgroup base CAT patch series. The last year's patch series had gone 16
> versions already. Because the first 12 patches have been reviewed many
> times, we keep them untouched (except removing cgroup code in patch 8 and
> some unused cdp code in patch 11) and release other patches on top of the
> first 12 patches.

Which is not making the review any simpler. In order to understand the
modifications I have to go back and page in the original stuff from last year
once again. So I have to read the original patch first to understand the
modifications and then get the overall picture of the new stuff. Please fold
stuff back to the proper places so I can start reviewing this thing under the
new design idea instead of twisting my brain around two designs.

> I fully agree this patch should be split if we want to have a good overall
> patch series.

Good.

Thanks,

tglx