Re: [PATCH] uapi: move forward declarations of internal structures

From: Alexey Dobriyan
Date: Wed Jul 13 2016 - 18:44:36 EST


On Wed, Jul 13, 2016 at 03:15:57PM -0700, Andrew Morton wrote:
> On Thu, 14 Jul 2016 00:58:08 +0300 Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:
>
> > Move "struct completion;".
> > Move "struct task_struct;".
>
> That tells us no more than does the diff.
>
> What's the reason for this change? Any perceptible benefit?

You're right.

Changelog should be

Don't user forward declarations of internal kernel structures
in headers exported to userspace.