Re: [PATCH] qla2xxx: setup data needed in ISR before setting up the ISR

From: Martin K. Petersen
Date: Thu Jul 14 2016 - 00:37:51 EST


>>>>> "Johannes" == Johannes Thumshirn <jthumshirn@xxxxxxx> writes:

Johannes> qla2xxx first calls request_irq() and then does the setup of
Johannes> the queue entry data needed in the interrupt handlers in when
Johannes> using MSI-X. This could lead to a NULL pointer dereference
Johannes> when an IRQ fires between the request_irq() call and the
Johannes> assignment of the qentry data structure to the
rsp-> msix field. A possible case for such a race would be in the kdump
Johannes> case when the HBA's IRQs are still enabled but the driver is
Johannes> undergoing a new initialisation and thus is not aware of
Johannes> already activated IRQs in the HBA.

Qlogic folks: Please review!

--
Martin K. Petersen Oracle Linux Engineering