Re: [patch 1/2] drivers/virt: fix the error handling in ioctl_dtprop()

[Ingo Molnar]

* Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:

> If strndup_user() user fails then it returns an error pointer and we
> pass that to kfree() which causes an oops.

Hm, in addition to this fix wouldn't it be better to not crash if kfree() gets 
passed an error pointer? Would that have changed the pattern of this particular 
bug?

Thanks,

	Ingo