Re: [PATCH] usb: ehci-platform: use helper variables in probe function

From: Alan Stern
Date: Thu Jul 14 2016 - 10:11:40 EST

On Wed, 13 Jul 2016, RafaÅ MiÅecki wrote:

> Probing function was using &dev->dev and dev->dev.of_node over 20 times
> so I believe it made sense to use helper variables for both of them.
> To avoid some uncommon variable name for struct device I first replaced
> existing dev variable with pdev.
> Signed-off-by: RafaÅ MiÅecki <zajec5@xxxxxxxxx>

Okay except for...

> - priv->num_phys = of_count_phandle_with_args(dev->dev.of_node,
> - "phys", "#phy-cells");
> + priv->num_phys = of_count_phandle_with_args(np, "phys",
> + "#phy-cells");

Please indent continuation lines two tab stops beyond the original
line, to match the style in the rest of the source file.

With that change,

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

Alan Stern