Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

[Matt Wilson]

On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote:
> This is a driver for the ENA family of networking devices.
> 
> Signed-off-by: Netanel Belgazal <netanel@xxxxxxxxxxxxxxxxx>
> ---
> 
> Notes:
>     Changes in v3:
>     - Fix compilation warning for 32bit systems. [kbuild test rebot]
>     - Replace netdev->num_tx_queues with adapter->num_queues in ethtool. [ben@xxxxxxxxxxxxxxx]
>     - Use get_link_ksettings instread of get_settings (deprecated ethtool API). [ben@xxxxxxxxxxxxxxx]
>     - Remove rna_nway_reset (ethtool). [ben@xxxxxxxxxxxxxxx]
>     - Add missing break in switch condition. [ben@xxxxxxxxxxxxxxx]
>     - Increase driver version to 1.0.2
>     
>     Changes in v2:
>     - Increment driver version to 1.0.1
>     - Reorder the initialization of the workqueus and the timer service
>     - Initialize last_keep_alive_jiffies in probe
>     - Remove ena_trc_* functions in favor of pr_* [davem@xxxxxxxxxxxxx]
>     - Fix Tx interrupt control register value [romieu@xxxxxxxxxxxxx]
>     - Edit ena.txt to focus on technical details [romieu@xxxxxxxxxxxxx]
>     - Rename small_copy_len tunable to rx_copybreak [benjamin.poirier@xxxxxxxxx]
>     - Change uint32_t to u32 [romieu@xxxxxxxxxxxxx]
>     - Return error in ena_com_set_hash_ctrl [rami.rosen@xxxxxxxxx]
>     - Fix API documentation [rami.rosen@xxxxxxxxx]
>     - Remove redundant check in ena_com_mem_addr_set [romieu@xxxxxxxxxxxxx]
>     - Add local variables for allocation methods to improve readability [romieu@xxxxxxxxxxxxx]
>     - Replace dma_alloc_coherent and __GFP_ZERO flag with dma_zalloc_coherent [romieu@xxxxxxxxxxxxx]
>     - Fix style when using dma_alloc_coherent [romieu@xxxxxxxxxxxxx]
>     - Tx xmit - In case of an error drop the packet and return NETDEV_TX_OK [romieu@xxxxxxxxxxxxx]
>     - Reduce the number of parameters in ena_get_dev_stats [romieu@xxxxxxxxxxxxx]
>     - Return ret and not 0 in ena_com_set_hash_ctrl [rami.rosen@xxxxxxxxx]
>     - Do not initialize variables if the function doesn't read them before the second write [romieu@xxxxxxxxxxxxx]
>     - Enums - Replace space with tabs to line the assign value [romieu@xxxxxxxxxxxxx]
>     - Remove redundant comments [romieu@xxxxxxxxxxxxx]
>     
>     TODO:
>     - Add bytes variable to set_coalesce ethtool callback and use this callback
>       instead of dedicated sysfs files.

Dave and Benjamin,

Do you want to see the interrupt moderation extensions to ethtool and
the sysfs nodes removed before this lands in net-next? Or should
Netanel remove the sysfs bits until we can extend the ethtool
interfaces to cover the parameters that ena uses?

--msw