Re: [patch net-next 2/2] devlink: fix trace format string

From: Steven Rostedt
Date: Thu Jul 14 2016 - 13:18:40 EST


On Thu, 14 Jul 2016 10:07:38 -0700
Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:

> On 07/14/16 02:37, Jiri Pirko wrote:
> > From: Arnd Bergmann <arnd@xxxxxxxx>
> >
> > Including devlink.h on ARM and probably other 32-bit architectures results in
> > a harmless warning:
> >
> > In file included from ../include/trace/define_trace.h:95:0,
> > from ../include/trace/events/devlink.h:51,
> > from ../net/core/devlink.c:30:
> > include/trace/events/devlink.h: In function 'trace_raw_output_devlink_hwmsg':
> > include/trace/events/devlink.h:42:12: error: format '%lu' expects argument of type 'long unsigned int', but argument 10 has type 'size_t {aka unsigned int}' [-Werror=format=]
> >
> > The correct format string for 'size_t' is %zu, not %lu, this works on all
> > architectures.
> >
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> > Fixes: e5224f0fe2ac ("devlink: add hardware messages tracing facility")
> > Signed-off-by: Jiri Pirko <jiri@xxxxxxxxxxxx>
>
> Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>

ditto!

-- Steve