Re: [RT PATCH 1/2] timers: wakeup all timer waiters

From: Sebastian Andrzej Siewior
Date: Thu Jul 14 2016 - 14:37:49 EST


On 07/14/2016 07:19 PM, Steven Rostedt wrote:
>> While doing so I noticed that we drop the base lock during timer
>> invocations and so it could be possible that we have two invocations
>> of del_timer_sync() on a timer on the same "base" (one after the
>> other). This is patch #1.
>>
>> After that I saw that we do the wake up under the base lock but there
>> is no reason for it. So here is patch #2.
>>
>> Patch #1 is something that could happen in theory and I did not run in
>> any problem.
>>
>
> OK, so patch 2 was just discovered by reviewing code?

both, not just patch 2.

>
> -- Steve

Sebastian