Re: [PATCH] KVM: release anon file in failure path of vm creation
From: Al Viro
Date: Thu Jul 14 2016 - 22:26:14 EST
On Fri, Jul 15, 2016 at 10:22:04AM +0800, Liu Shuo wrote:
> > You have no warranty whatsoever that descriptor table has not been changed
> > by that point. You should *NEVER* use sys_close() on failure exit paths
> Could you please elaborate why we're not sure descriptor table's changing at the point?
Because that could be called by one thread while another (having guessed the
descriptor you are about to get) does close()/dup2()/etc.