Re: linux-next: build failure after merge of the luto-misc tree

From: Peter Zijlstra
Date: Fri Jul 15 2016 - 03:31:32 EST


On Fri, Jul 15, 2016 at 09:22:43AM +0200, Peter Zijlstra wrote:
> On Fri, Jul 15, 2016 at 05:06:54PM +1000, Stephen Rothwell wrote:
> > interacting with commit
> >
> > 2a00f026a15d ("tools: Fix up BITS_PER_LONG setting")
> >
> > from the tip tree.
>
> Yuck.. that thing is horrid :/
>
> What's wrong with so?
>
> And if you really want to retain CONFIG_64BIT (because other headers
> might want it, and they currently do not) then do something like:
>
> #ifdef __LP64__
> #define CONFIG_64BIT
> #else
> #define CONFIG_32BIT
> #endif
>
> All GCC versions I checked have __CHAR_BIT__ and __SIZEOF_LONG__.
>
> (and I checked most everything from 4.4 - 6.1)

clang-3.8 also defines all three of those, and I don't consider that a
usable compiler as it doesn't even build a kernel.