RE: [PATCH V1] regulator: da9210: addition of device tree support

[Steve Twiss]

On 14 July 2016 16:48, Mark Brown wrote:

> To: Steve Twiss
> Cc: DEVICETREE; LINUXKERNEL; Liam Girdwood; Mark Rutland; Rob Herring;
> Support Opensource
> Subject: Re: [PATCH V1] regulator: da9210: addition of device tree support
> 
> On Wed, Jul 13, 2016 at 04:41:19PM +0100, Steve Twiss wrote:
> 
> > Two files are modified, the driver source file and the binding document.
> > Updates for the regulator source file include an .of_match_table entry, node
> > match checking in the probe() function for a compatible da9210 string, and
> > a new "BUCK" regulator entry. The binding documentation changes have been
> > made to reflect these updates.
> 
> If the device only has one regulator and no other functionality I'd
> expect the properties to just be in the top level node for the device -
> no need to go fiddling around with a subnode to hold another subnode to
> hold all the properties.

Agreed.
I will revert those changes to the device tree and re-submit V2.