Re: [PATCH 25/36] usb: serial: ti_usb_3410_5052: Check old_termios parameter in set_termios

From: Johan Hovold
Date: Fri Jul 15 2016 - 08:14:38 EST


On Thu, May 12, 2016 at 10:48:57AM +0200, Mathieu OTHACEHE wrote:
> The old_termios parameter is never used in set_termios callback.

There we go. :)

> Add a check to old_termios to see if we can return right away because
> there is nothing to change.
> Add a check to old_termios CBAUD to see if we can set DTR/RTS because
> last speed was B0.

Try splitting that up in two patches.

> Also pass NULL for old_termios in open callback because it is the
> initial call to set_termios.

That's what you need to do of course (not change the prototype as I said
earlier).

Thanks,
Johan