Re: [PATCH 1/3] perf script python: Fix string vs byte array resolving

From: Jiri Olsa
Date: Fri Jul 15 2016 - 12:13:40 EST


On Fri, Jul 15, 2016 at 12:02:31PM -0400, Steven Rostedt wrote:

SNIP

> > for "AA\1\0" this returns "1" although that should return "0".
> >
> > orig len 4
> > decremented len 3
> > for:
> > 0 1
> >
> > index 2 would not be inspected. Or am I missing something?
> >
> > I think that the for check should be "i < len"
>
> Yes it should be. I think we got the two solutions mixed up.
>
> With the above len--, it should be i < len, but when we did the check
> for zero at the end, we needed the i < len - 1

ugh right.. should be 'i < len' check in the for loop,

there's also the patch 2/3 that needs to be changed

Arnaldo,
please let me know if you need me to resend this.

thanks,
jirka