Re: [RFT PATCH v2] [media] exynos4-is: Fix fimc_is_parse_sensor_config() nodes handling

From: Nicolas Dufresne
Date: Fri Jul 15 2016 - 13:05:36 EST


Le vendredi 15 juillet 2016 Ã 12:53 -0400, Nicolas Dufresne a ÃcritÂ:
> Le jeudi 21 avril 2016 Ã 09:21 -0400, Javier Martinez Canillas a
> ÃcritÂ:
> > Hello Sylwester,
> >
> > On 03/23/2016 08:41 PM, Javier Martinez Canillas wrote:
> > > The same struct device_node * is used for looking up the I2C
> > > sensor, OF
> > > graph endpoint and port. So the reference count is incremented
> > > but
> > > not
> > > decremented for the endpoint and port nodes.
> > >
> > > Fix this by having separate pointers for each node looked up.
> > >
> > > Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
> > >
> >
> > Any comments about this patch?
>
> Tested-by: Nicolas Dufresne <nicoas.dufresne@xxxxxxxxxxxxx>

There a typo here.

Tested-by: Nicolas Dufresne <nicolas.dufresne@xxxxxxxxxxxxx>

>
> Note: I could not verify that leak is gone, but I could verify that
> this driver is still working properly after the change.
>
> >
> > Best regards,

Attachment: signature.asc
Description: This is a digitally signed message part