Re: [patch] testing/radix-tree: fix a macro expansion bug

From: Ross Zwisler
Date: Fri Jul 15 2016 - 17:42:21 EST


On Sat, Jul 16, 2016 at 12:09:53AM +0300, Dan Carpenter wrote:
> There are no parentheses around this macro and it causes a problem when
> we do:
>
> index = rand() % THRASH_SIZE;
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Acked-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>

>
> diff --git a/tools/testing/radix-tree/tag_check.c b/tools/testing/radix-tree/tag_check.c
> index b7447ce..b0ac057 100644
> --- a/tools/testing/radix-tree/tag_check.c
> +++ b/tools/testing/radix-tree/tag_check.c
> @@ -122,7 +122,7 @@ enum {
> NODE_TAGGED = 2,
> };
>
> -#define THRASH_SIZE 1000 * 1000
> +#define THRASH_SIZE (1000 * 1000)
> #define N 127
> #define BATCH 33
>