Re: [PATCH] s390/pci: Delete an unnecessary check before the function call "pci_dev_put"

[Martin Schwidefsky]

On Sat, 16 Jul 2016 20:40:23 +0200
SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:

> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Sat, 16 Jul 2016 20:15:17 +0200
> 
> The pci_dev_put() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  arch/s390/pci/pci_event.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/s390/pci/pci_event.c b/arch/s390/pci/pci_event.c
> index fb2a9a5..c2b27ad 100644
> --- a/arch/s390/pci/pci_event.c
> +++ b/arch/s390/pci/pci_event.c
> @@ -145,8 +145,7 @@ static void __zpci_event_availability(struct zpci_ccdf_avail *ccdf)
>  	default:
>  		break;
>  	}
> -	if (pdev)
> -		pci_dev_put(pdev);
> +	pci_dev_put(pdev);
>  }
> 
>  void zpci_event_availability(void *data)

Applied,  thanks.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.