Re: [PATCH 3/3] perf tests: Add is_printable_array test

[Jiri Pirko]

Sat, Jul 16, 2016 at 06:11:20PM CEST, jolsa@xxxxxxxxxx wrote:
>Add automated test for is_printable_array function.
>
>Link: http://lkml.kernel.org/n/tip-if70lj3zhdc3csdqm5webjvc@xxxxxxxxxxxxxx
>Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
>---
> tools/perf/tests/Build                |  1 +
> tools/perf/tests/builtin-test.c       |  4 ++++
> tools/perf/tests/is_printable_array.c | 36 +++++++++++++++++++++++++++++++++++
> tools/perf/tests/tests.h              |  1 +
> 4 files changed, 42 insertions(+)
> create mode 100644 tools/perf/tests/is_printable_array.c
>
>diff --git a/tools/perf/tests/Build b/tools/perf/tests/Build
>index 4158422cc2a6..cb20ae1c0d35 100644
>--- a/tools/perf/tests/Build
>+++ b/tools/perf/tests/Build
>@@ -40,6 +40,7 @@ perf-y += event_update.o
> perf-y += event-times.o
> perf-y += backward-ring-buffer.o
> perf-y += sdt.o
>+perf-y += is_printable_array.o
> 
> $(OUTPUT)tests/llvm-src-base.c: tests/bpf-script-example.c tests/Build
> 	$(call rule_mkdir)
>diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
>index 4dd2d050788a..10eb30686c9c 100644
>--- a/tools/perf/tests/builtin-test.c
>+++ b/tools/perf/tests/builtin-test.c
>@@ -222,6 +222,10 @@ static struct test generic_tests[] = {
> 		.func = test__sdt_event,
> 	},
> 	{
>+		.desc = "Test is_printable_array function",
>+		.func = test__is_printable_array,
>+	},
>+	{
> 		.func = NULL,
> 	},
> };
>diff --git a/tools/perf/tests/is_printable_array.c b/tools/perf/tests/is_printable_array.c
>new file mode 100644
>index 000000000000..42e13393e502
>--- /dev/null
>+++ b/tools/perf/tests/is_printable_array.c
>@@ -0,0 +1,36 @@
>+#include <linux/compiler.h>
>+#include "tests.h"
>+#include "debug.h"
>+#include "util.h"
>+
>+int test__is_printable_array(int subtest __maybe_unused)
>+{
>+	char buf1[] = { 'k', 'r', 4, 'v', 'a', 0 };
>+	char buf2[] = { 'k', 'r', 'a', 'v', 4, 0 };
>+	struct {
>+		char		*buf;
>+		unsigned int	 len;
>+		int		 ret;
>+	} t[] = {
>+		{ (char *) "krava",	sizeof("krava"),	1 },
>+		{ (char *) "krava",	sizeof("krava") - 1,	0 },

"a cow" ? Really? :))