Re: [PATCH net] bnxt_en: Remove locking around txr->dev_state

From: Michael Chan
Date: Mon Jul 18 2016 - 16:06:56 EST


On Mon, Jul 18, 2016 at 1:02 PM, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote:
> txr->dev_state was not consistently manipulated with the acquisition of
> the per-queue lock, after further inspection the lock does not seem
> necessary, either the value is read as BNXT_DEV_STATE_CLOSING or 0.
>
> Reported-by: coverity (CID 1339583)
> Fixes: c0c050c58d840 ("bnxt_en: New Broadcom ethernet driver.")
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>

Thanks Florian.

Acked-by: Michael Chan <michael.chan@xxxxxxxxxxxx>