Re: [patch] crypto: sha256-mb - cleanup a || vs | typo
From: Tim Chen
Date: Mon Jul 18 2016 - 18:12:40 EST
On Mon, 2016-07-18 at 10:59 +0200, Pavel Machek wrote:
> On Fri 2016-07-08 10:19:26, Linus Torvalds wrote:
> >
> > [ rare comment rant. I think I'll do this once, and then ignore the discussion ]
> >
> > On Fri, Jul 8, 2016 at 9:45 AM, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> > >
> > >
> > > Nack.ÂÂAs I said the commenting style in the crypto API is the
> > > same as the network stack.ÂÂSo unless we decide to change both
> > > please stick to the current style.
> > Can we please get rid of the brain-damaged stupid networking comment
> > syntax style, PLEASE?
> Please? :-). Having different comment styles between networking and
> the rest is confusing.
>
> And yes, this uglyness is documented for net/ and drivers/net/, but
> not for crypto/, so at the very least Documentation/CodingStyle should
> be updated.
>
> Pavel
The cleanup patch has already been merged. ÂThanks.
Tim