Re: [PATCH v1] ESIA : Dummy eisa_driver_register should return error code

From: Christoph Hellwig
Date: Tue Jul 19 2016 - 00:32:11 EST


On Tue, Jul 19, 2016 at 12:15:01AM +0530, Arvind Yadav wrote:
> The inline eisa_driver_register stub simply allows compilation on
> systems with CONFIG_EISA disabled. the dummy eisa_driver_register
> does not register an *_eisa_driver at all. The inline
> eisa_driver_register should return to indicate lack of support
> when attempting to register an *_eisa_driver on such a system with
> CONFIG_EISA disabled.

Why? The idea is that you can simply leave the stub in if registering
say PCI / EISA. With your change such a driver will fail to load even
if it could serve PCI device in a !CONFIG_EISA config, which is the
behavior we want.