Re: linux-next: build failure after merge of the wireless-drivers-next tree
From: RafaÅ MiÅecki
Date: Tue Jul 19 2016 - 02:51:54 EST
On 19 July 2016 at 08:30, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote:
> Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> writes:
>
>> After merging the wireless-drivers-next tree, today's linux-next build
>> (powerpc allyesconfig) failed like this:
>>
>> drivers/mtd/devices/bcm47xxsflash.c: In function 'bcm47xxsflash_bcma_probe':
>> drivers/mtd/devices/bcm47xxsflash.c:299:17: error: implicit declaration of function 'ioremap_cache' [-Werror=implicit-function-declaration]
>> b47s->window = ioremap_cache(res->start, resource_size(res));
>> ^
>> drivers/mtd/devices/bcm47xxsflash.c:299:15: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>> b47s->window = ioremap_cache(res->start, resource_size(res));
>> ^
>>
>> Caused by commit
>>
>> 57d8f7dd2132 ("bcma: allow enabling serial flash support on non-MIPS SoCs")
>>
>> I have reverted that commit for today.
>
> Thanks, kbuild bot also notified about this.
>
> RafaÅ, as the merge window is getting really close I would like to
> revert this for now and we can reapply it once we the problem is fully
> solved. And we can use my pending branch for build testing the patch
> with kbuild bot. What do you think?
The simplest fix sounds pretty much as simple as the revert. In the
seconds thread I was considering two fixes: switching to memremap and
adding depends on.
What about trying a simple "depends on"?
--
RafaÅ