Re: [PATCH] sh-DWARF: Delete unnecessary checks before the function call "mempool_destroy"

[SF Markus Elfring]

> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Mon, 16 Nov 2015 08:20:36 +0100
> 
> The mempool_destroy() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the calls is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  arch/sh/kernel/dwarf.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/sh/kernel/dwarf.c b/arch/sh/kernel/dwarf.c
> index 9d209a0..e1d751a 100644
> --- a/arch/sh/kernel/dwarf.c
> +++ b/arch/sh/kernel/dwarf.c
> @@ -1009,10 +1009,8 @@ static void __init dwarf_unwinder_cleanup(void)
>  	rbtree_postorder_for_each_entry_safe(cie, next_cie, &cie_root, node)
>  		kfree(cie);
>  
> -	if (dwarf_reg_pool)
> -		mempool_destroy(dwarf_reg_pool);
> -	if (dwarf_frame_pool)
> -		mempool_destroy(dwarf_frame_pool);
> +	mempool_destroy(dwarf_reg_pool);
> +	mempool_destroy(dwarf_frame_pool);
>  	kmem_cache_destroy(dwarf_reg_cachep);
>  	kmem_cache_destroy(dwarf_frame_cachep);
>  }
> 

How do you think about to integrate this update suggestion
into another source code repository?

Regards,
Markus