Re: [PATCH 1/4] extcon: arizona: Remove the usage of extcon_update_state()

From: Charles Keepax
Date: Wed Jul 20 2016 - 04:22:42 EST


On Wed, Jul 20, 2016 at 04:38:44PM +0900, Chanwoo Choi wrote:
> This patch remvoes the usage of extcon_update_state() because
> the extcon_update_state() use directly the bit masking calculation
> to change the state of external connector without the unique id of
> external connector. It makes the code diffcult to read it.
> So, this patch uses the extcon_set_cable_state_() instead.
>
> Cc: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> Cc: patches@xxxxxxxxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> ---

Acked-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

Thanks,
Charles