Re: [PATCH v7] [media] pci: Add tw5864 driver

[Hans Verkuil]

On 07/20/2016 03:07 PM, Andrey Utkin wrote:
> Changes since v6:
>  - Change tw5864_input_std_get() behaviour as suggested by Hans, and also simplify
>  - tw5864_from_v4l2_std(): drop WARN_ON_ONCE on returning STD_INVALID
>  - tw5864_prepare_frame_headers(): not only WARN_ON_ONCE, but also return if buffer space is too small
>  - tw5864_frameinterval_get(): return -EINVAL instead of "1" on failure
> 
> Granular git log: https://github.com/bluecherrydvr/linux/commits/release/tw5864/pre_1.26/drivers/media/pci/tw5864
> 
> ---8<---
> Support for boards based on Techwell TW5864 chip which provides
> multichannel video & audio grabbing and encoding (H.264, MJPEG,
> ADPCM G.726).
> 
> This submission implements only H.264 encoding of all channels at D1
> resolution.
> 
> Thanks to Mark Thompson <sw@xxxxxxxxx> for help, and for contribution of
> H.264 startcode emulation prevention code.
> 
> Signed-off-by: Andrey Utkin <andrey.utkin@xxxxxxxxxxxxxxxxxxx>
> Tested-by: Andrey Utkin <andrey.utkin@xxxxxxxxxxxxxxxxxxx>

Looks good. Once we moved to v4.8-rc1 in 3 weeks time or so I'll make a pull request for this.

Regards,

	Hans