Re: [PATCH 3/9] staging: ks7010: Return directly after a failed kmalloc()

[Wolfram Sang]

On Wed, Jul 20, 2016 at 08:40:11PM +0200, SF Markus Elfring wrote:
> >>> @@ -713,10 +713,8 @@ static int ks7010_sdio_update_index(struct ks_wlan_private *priv, u32 index)
> >>>  	unsigned char *data_buf;
> >>>
> >>>  	data_buf = kmalloc(sizeof(u32), GFP_KERNEL);
> >>> -	if (!data_buf) {
> >>> -		rc = 1;
> >>> -		goto error_out;
> >>> -	}
> >>> +	if (!data_buf)
> >>> +		return 1;
> >>
> >> One could rather wonder why the function has such strange error values...
> > 
> > Agreed. Markus, can you check if we can use -ENOMEM in those places.
> 
> I find that I do not know this software good enough at the moment
> so that I could safely decide on the shown special error values.
> I guess that further clarification might be needed for affected
> implementation details.

That's OK, too.

Acked-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature