Re: [PATCH v2] fuse: fuse_flush must check mapping->flags for errors

From: Miklos Szeredi
Date: Thu Jul 21 2016 - 06:28:49 EST


On Wed, Jul 20, 2016 at 3:12 AM, Maxim Patlasov <mpatlasov@xxxxxxxxxxxxx> wrote:
> fuse_flush() calls write_inode_now() that triggers writeback, but actual
> writeback will happen later, on fuse_sync_writes(). If an error happens,
> fuse_writepage_end() will set error bit in mapping->flags. So, we have to
> check mapping->flags after fuse_sync_writes().
>
> Changed in v2:
> - fixed silly type: check must be *after* fuse_sync_writes()

I applied both with a cleanup patch at the end to use the
filemap_check_errors() helper, which does exactly this.

Thanks,
Miklos