Re: [RFC PATCH v2 0/3] fix overlayfs locks and leases

[Jeff Layton]

On Thu, 2016-07-21 at 15:53 +0200, Miklos Szeredi wrote:
> I've split out the writecount handling and changed it around so that
> underlying layers are consistent and yet leases work correctly on
> overlayfs.
> 
> Also pushed to the tip of
> 
> Â git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-next
> 
> Thanks,
> Miklos
> ---
> 
> Miklos Szeredi (3):
> Â locks: fix file locking on overlayfs
> Â vfs: make argument of d_real_inode() const
> Â vfs: do get_write_access() on upper layer of overlayfs
> 
> Âfs/locks.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂ| 53 ++++++++++++++++++++++++++++---------------------
> Âfs/namespace.cÂÂÂÂÂÂÂÂÂÂ|ÂÂ2 +-
> Âfs/open.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ| 17 +++++++++++++---
> Âfs/overlayfs/super.cÂÂÂÂ|ÂÂ2 +-
> Âinclude/linux/dcache.hÂÂ|ÂÂ5 +++--
> Âinclude/linux/fs.hÂÂÂÂÂÂ| 16 +++++++++++++--
> Âinclude/uapi/linux/fs.h |ÂÂ1 +
> Â7 files changed, 64 insertions(+), 32 deletions(-)
> 

Looks pretty sane overall.

Also, when I mentioned accessing the writable layer in openwrt in the
last set, I forgot that you typically only do reads on it, so the
writecount wouldn't be affected in the case of accessing to do backups.
So, I'm not sure I had a legit objection to the earlier patch, but I
think this looks a little cleaner anyway:

Acked-by: Jeff Layton <jlayton@xxxxxxxxxxxxxxx>