Re: [PATCH] drm/vmwgfx: Delete an unnecessary check before the function call "vfree"

[Sinclair Yeh]

Looks good.  Thanks!

Reviewed-by: Sinclair Yeh <syeh@xxxxxxxxxx>

On Fri, Jul 22, 2016 at 01:45:40PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Fri, 22 Jul 2016 13:31:00 +0200
> 
> The vfree() function performs also input parameter validation.
> Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> index 1a1a87c..dc5beff 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> @@ -3625,9 +3625,7 @@ static int vmw_resize_cmd_bounce(struct vmw_sw_context *sw_context,
>  				   (sw_context->cmd_bounce_size >> 1));
>  	}
>  
> -	if (sw_context->cmd_bounce != NULL)
> -		vfree(sw_context->cmd_bounce);
> -
> +	vfree(sw_context->cmd_bounce);
>  	sw_context->cmd_bounce = vmalloc(sw_context->cmd_bounce_size);
>  
>  	if (sw_context->cmd_bounce == NULL) {
> -- 
> 2.9.2
>