Re: [PATCH 3/5] mm: Remove reclaim and compaction retry approximations

From: Johannes Weiner
Date: Fri Jul 22 2016 - 11:57:52 EST


On Thu, Jul 21, 2016 at 03:10:59PM +0100, Mel Gorman wrote:
> If per-zone LRU accounting is available then there is no point
> approximating whether reclaim and compaction should retry based on pgdat
> statistics. This is effectively a revert of "mm, vmstat: remove zone and
> node double accounting by approximating retries" with the difference that
> inactive/active stats are still available. This preserves the history of
> why the approximation was retried and why it had to be reverted to handle
> OOM kills on 32-bit systems.
>
> Signed-off-by: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx>

I like this version of should_reclaim_retry() much better ;)

Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>