Re: [PATCH -next] pinctrl: fix build, PINCTRL_CYGNUS_MUX depends on OF

From: Randy Dunlap
Date: Fri Jul 22 2016 - 14:17:22 EST


On 07/22/16 11:09, Ray Jui wrote:
> Hi Randy,
>
> On 7/22/2016 11:06 AM, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>>
>> Fix pinctrl-cygnus-mux.c build when ARCH_BCM_CYGNUS is not enabled
>> but COMPILE_TEST is enabled by making the driver depend on OF.
>>
>> ../drivers/pinctrl/bcm/pinctrl-cygnus-mux.c:739:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function)
>> .dt_node_to_map = pinconf_generic_dt_node_to_map_group,
>>
>> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>> Cc: Ray Jui <rjui@xxxxxxxxxxxx>
>> Cc: bcm-kernel-feedback-list@xxxxxxxxxxxx
>> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
>> Cc: linux-gpio@xxxxxxxxxxxxxxx
>> ---
>> drivers/pinctrl/bcm/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- linux-next-20160722.orig/drivers/pinctrl/bcm/Kconfig
>> +++ linux-next-20160722/drivers/pinctrl/bcm/Kconfig
>> @@ -60,6 +60,7 @@ config PINCTRL_IPROC_GPIO
>> config PINCTRL_CYGNUS_MUX
>> bool "Broadcom Cygnus IOMUX driver"
>> depends on (ARCH_BCM_CYGNUS || COMPILE_TEST)
>> + depends on OF
>> select PINMUX
>> select GENERIC_PINCONF
>> default ARCH_BCM_CYGNUS
>>
>
> Thanks, but a fix was already submitted by Arnd and picked up by Linus: https://lkml.org/lkml/2016/7/15/649

OK, it's just not in linux-next yet.

Thanks.


--
~Randy