Re: [PATCH] add u64 number parser

From: James Smart
Date: Sat Jul 23 2016 - 11:52:37 EST



On 7/22/2016 6:32 PM, Bart Van Assche wrote:
On 07/22/16 17:23, James Smart wrote:
+ buf = kmalloc(len + 1, GFP_KERNEL);
+ if (!buf)
+ return -ENOMEM;
+ memcpy(buf, s->from, len);
+ buf[len] = '\0';

Hello James,

Have you considered to combine the above kmalloc() and memcpy() calls into a single kasprintf(GFP_KERNEL, "%.*s", len, s->from) call?

Bart.


No, I followed the example of existing parse functions in the file.

-- james