Re: [PATCH 2/2] mm: optimize copy_page_to/from_iter_iovec

[Andi Kleen]

Mikulas Patocka <mpatocka@xxxxxxxxxx> writes:
>  	copy = min(bytes, iov->iov_len - skip);
>  
> +#ifdef CONFIG_HIGHMEM
>  	if (!fault_in_pages_writeable(buf, copy)) {

If you use IS_ENABLED in the if here ...

>  	kunmap(page);
> +
> +#ifdef CONFIG_HIGHMEM
>  done:
> +#endif

... you don't need this ifdef.

-Andi


-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only