Re: [PATCH -next] xtensa: Fix build error due to missing include file

[Guenter Roeck]

On 07/23/2016 05:45 PM, Max Filippov wrote:
> On Sun, Jul 24, 2016 at 3:24 AM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> > Commit 69d99e6c0d621f ("xtensa: Remove unnecessary of_platform_populate
> > with default match table") dropped various include files from
> > arch/xtensa/kernel/setup.c. This results in the following build error.
> >
> > arch/xtensa/kernel/setup.c: In function âxtensa_dt_io_areaâ:
> > arch/xtensa/kernel/setup.c:213:2: error:
> >          implicit declaration of function âof_read_ulongâ
> >
> > Fixes: 69d99e6c0d621f ("xtensa: Remove unnecessary of_platform_populate with default match table")
> > Cc: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>
> > Cc: Rob Herring <robh@xxxxxxxxxx>
> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > ---
> > I would suggest to merge this patch into the commit causing the problem
> > if possible.
> >
> >   arch/xtensa/kernel/setup.c | 1 +
> >   1 file changed, 1 insertion(+)
>
> Acked-by: Max Filippov <jcmvbkbc@xxxxxxxxx>

Heads up: xtensa images build after this patch, but the image that
previously failed to build (generic_kc705_defconfig) doesn't boot,
at least not with qemu. I don't know if this is caused by 69d99e6c0d621f
or by some other patch.

Guenter