[PATCH v3 04/13] sched/core: Remove unnecessary null-pointer check

From: Morten Rasmussen
Date: Mon Jul 25 2016 - 09:35:17 EST


Checking if the sched_domain pointer returned by sd_init() is null seems
pointless as sd_init() neither checks if it is valid to begin with nor
set it to null.

cc: Ingo Molnar <mingo@xxxxxxxxxx>
cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>

Signed-off-by: Morten Rasmussen <morten.rasmussen@xxxxxxx>
---
kernel/sched/core.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 4e9617a7e7d9..0a40beb46841 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -6824,8 +6824,6 @@ struct sched_domain *build_sched_domain(struct sched_domain_topology_level *tl,
struct sched_domain *child, int cpu)
{
struct sched_domain *sd = sd_init(tl, cpu);
- if (!sd)
- return child;

cpumask_and(sched_domain_span(sd), cpu_map, tl->mask(cpu));
if (child) {
--
1.9.1