Re: [PATCH 2/3] phy: rockchip-emmc: Be tolerant to card clock of 0 in power on

From: Doug Anderson
Date: Mon Jul 25 2016 - 10:19:22 EST


On Sun, Jul 24, 2016 at 10:57 PM, Kishon Vijay Abraham I <kishon@xxxxxx> wrote:
>> Did you agree on how to move forward with this change?
> I think still few things are not very clear especially on what should be
> handled in PHY when the clock rate changes or if any new PHY APIs are required
> to handle any clock changes etc..
> But since this actually gets MMC working in rockchip, I'd be okay to merge this
> now. Though I'd expect this to be refined in the future release cycles.
> Reviewed-by: Kishon Vijay Abraham I <kishon@xxxxxx>

Thank you. Agreed that I don't particularly like the revert and last
I checked with Shawn at Rockchip he was trying to find a better
solution. ...but I also agree that landing the revert is better than
not landing it while we wait for a better solution.

IMHO in this particular case PHY API changes shouldn't be needed since
we should be able to use the CCF notifications. ...but we need to
figure out how to do that in the case of the current card clock since
it's not really a fully fledged clock and doesn't support
notifications. We might need to get advice from CCF guys...