Re: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open

From: Jens Axboe
Date: Mon Jul 25 2016 - 16:49:01 EST


On 06/30/2016 05:18 AM, Jiri Kosina wrote:
From: Jiri Kosina <jkosina@xxxxxxx>

Commit 09954bad4 ("floppy: refactor open() flags handling"), as a
side-effect, causes open(/dev/fdX, O_ACCMODE) to fail. It turns out that
this is being used setfdprm userspace for ioctl-only open().

Reintroduce back the original behavior wrt !(FMODE_READ|FMODE_WRITE)
modes, while still keeping the original O_NDELAY bug fixed.

Cc: stable@xxxxxxxxxxxxxxx # v4.5+
Reported-by: Wim Osterholt <wim@xxxxxxxxxxxxxx>
Tested-by: Wim Osterholt <wim@xxxxxxxxxxxxxx>
Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>

Added for this series, thanks.

--
Jens Axboe