Re: [PATCH] staging: ks7010: declare private functions static

[Wolfram Sang]

On Tue, Jul 26, 2016 at 06:48:00AM +0000, Nicholas Mc Guire wrote:
> On Mon, Jul 25, 2016 at 11:04:18PM +0200, Wolfram Sang wrote:
> > On Mon, Jul 25, 2016 at 09:22:27PM +0200, Nicholas Mc Guire wrote:
> > > Private functions in ks_hostif.c can be declared static. 
> > > 
> > > Fixes: 13a9930d15b4 ("staging: ks7010: add driver from Nanonote extra-repository")
> > > 
> > > Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx>
> > 
> > Reviewed-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>
> > 
> > drivers/staging/ks7010/ks7010_sdio.c and
> > drivers/staging/ks7010/ks_wlan_net.c have similar warnings in case you'd
> > like to fix those, too.)
> > 
> the cases found regarding completion were:
> ./drivers/staging/ks7010/ks_hostif.c:80 treating signal case as success
> ./drivers/staging/ks7010/ks_wlan_net.c:109 treating signal case as success
> ./drivers/staging/ks7010/ks7010_sdio.c:901 treating signal case as success
> ./drivers/staging/ks7010/ks7010_sdio.c:929 treating signal case as success
> ./drivers/video/fbdev/exynos/exynos_mipi_dsi_common.c:383 treating signal case as success
> ./drivers/video/fbdev/exynos/exynos_mipi_dsi_common.c:247 treating signal case as success
> 
> will be going through all of them in the next days. 

Awesome, thanks!

I meant the "should it be static?" sparse warnings here, though :)

Attachment: signature.asc
Description: PGP signature