Re: [PATCH] s390/perf: fix 'start' address of module's map
From: Jiri Olsa
Date: Tue Jul 26 2016 - 02:54:45 EST
On Fri, Jul 22, 2016 at 10:47:34AM +0800, Songshan Gong wrote:
> Has the patch been accepted by upstream?
> å 7/21/2016 11:10 AM, Song Shan Gong åé:
> > At preset, when creating module's map, perf gets 'start' address by parsing
> > '/proc/modules', but it's module base address, isn't the start address of
> > '.text' section. In most archs, it's OK. But for s390, it places 'GOT' and
> > 'PLT' relocations before '.text' section. So there exists an offset between
> > module base address and '.text' section, which will incur wrong symbol
> > resolution for modules.
> > Fix this bug by getting 'start' address of module's map from parsing
> > '/sys/module/[module name]/sections/.text', not from '/proc/modules'.
> > Signed-off-by: Song Shan Gong <gongss@xxxxxxxxxxxxxxxxxx>
> > Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>
I think it's good to go, Arnaldo, could you please take this one?