Re: [PATCH 2/6] extcon: Add the support for extcon property according to extcon type

[Guenter Roeck]

On Tue, Jul 26, 2016 at 8:42 PM, Chanwoo Choi <cw00.choi@xxxxxxxxxxx> wrote:
> Hi Chris,
>
> On 2016ë 07ì 27ì 11:09, Chris Zhong wrote:
>> Hi Guernter
>>
>> On 07/27/2016 09:44 AM, Guenter Roeck wrote:
>>> Hi Chris,
>>>
>>> On Tue, Jul 26, 2016 at 6:15 PM, Chris Zhong <zyw@xxxxxxxxxxxxxx> wrote:
>>>
>>> [ ... ]
>>>
>>>>>      > +
>>>>>      > +/* Properties of EXTCON_TYPE_DISP. */
>>>>>      > +#define EXTCON_PROP_DISP_MIN           150
>>>>>      > +#define EXTCON_PROP_DISP_MAX           150
>>>>>      > +#define EXTCON_PROP_DISP_CNT   (EXTCON_PROP_DISP_MAX -
>>>>>      EXTCON_PROP_DISP_MIN)
>>>>>
>>>>>                   + 1
>>>>>
>>>>>
>>>>> ok.
>>>>
>>>> Tested with these "+1", it works for my DP patch.
>>>>
>>> You should be able to use
>>> https://chromium-review.googlesource.com/#/c/363623/1 as baseline (if
>>> you didn't do that already).
>>>
>>> Thanks,
>>> Guenter
>>
>> Thanks Guenter, and I saw this bug has fixed in extcon-test branch.
>>
>>
>
> Do you test it with extcon_set_property_capability()?
> And if you test this patch-es, could you send the tested-by tag for these patches?
>

For my part I did. Above link is public, so you should be able to see
the complete patch set which uses the new API from
drivers/extcon/extcon-cros_ec.c.

I'll re-test tomorrow with the updated patches from your test branch.

> I'll send the next version after a few days.

Great.

Thanks,
Guenter