RE: [PATCH 11/13] rapidio: modify for rev.3 specification changes

[Wood, Barry]

Hi Michael,

Alex is currently on vacation, but will return August 2.  He will resolve this issue at that time.

Cheers,
Barry

-----Original Message-----
From: Michael Ellerman [mailto:mpe@xxxxxxxxxxxxxx] 
Sent: Wednesday, July 27, 2016 12:53 AM
To: Bounine, Alexandre; Andrew Morton
Cc: Bounine, Alexandre; Matt Porter; Andre van Herk; Wood, Barry; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 11/13] rapidio: modify for rev.3 specification changes

Alexandre Bounine <alexandre.bounine@xxxxxxx> writes:

> Implement changes made in RapidIO specification rev.3 to LP-Serial 
> Physical Layer register definitions:
> - use per-port register offset calculations based on LP-Serial Extended
>   Features Block (EFB) Register Map type (I or II) with different per-port
>   offset step (0x20 vs. 0x40 respectfully).
> - remove deprecated Parallel Physical layer definitions and related code.
>
> Signed-off-by: Alexandre Bounine <alexandre.bounine@xxxxxxx>
> Tested-by: Barry Wood <barry.wood@xxxxxxx>
> Cc: Matt Porter <mporter@xxxxxxxxxxxxxxxxxxx>
> Cc: Andre van Herk <andre.van.herk@xxxxxxxxxxxxxxxxxxxxxxxxx>
> Cc: Barry Wood <barry.wood@xxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> ---
>  drivers/rapidio/devices/rio_mport_cdev.c |    2 +-
>  drivers/rapidio/devices/tsi721.c         |    8 +-
>  drivers/rapidio/rio-scan.c               |   74 +++----------
>  drivers/rapidio/rio.c                    |  149 ++++++++++++++-------------
>  drivers/rapidio/rio.h                    |    2 +-
>  drivers/rapidio/switches/tsi57x.c        |   26 ++---
>  include/linux/rio.h                      |   11 +--
>  include/linux/rio_regs.h                 |  167 +++++++++++++++++++++++------
>  8 files changed, 248 insertions(+), 191 deletions(-)

This is breaking the build for me on powerpc, for corenet64_smp_defconfig at least.

eg.

http://kisskb.ellerman.id.au/kisskb/buildresult/12750751/

Commit:   Add linux-next specific files for 20160722
	  13123042d0dbf7635f052efc2ae69fd9af624f1d
Compiler: powerpc-linux-gcc (GCC) 4.6.3

Possible errors
---------------

arch/powerpc/sysdev/fsl_rio.c:702:11: error: 'struct rio_mport' has no member named 'phy_type'
arch/powerpc/sysdev/fsl_rio.c:702:25: error: 'RIO_PHY_SERIAL' undeclared (first use in this function)
make[2]: *** [arch/powerpc/sysdev/fsl_rio.o] Error 1
make[1]: *** [arch/powerpc/sysdev] Error 2
make: *** [sub-make] Error 2

cheers