Re: [PATCH 2/3] staging: wilc1000: One function call less in mac_ioctl() after error detection

From: Julian Calaby
Date: Thu Jul 28 2016 - 08:03:01 EST

Hi Marcus,

On Mon, Jul 25, 2016 at 6:22 AM, SF Markus Elfring
<elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Sun, 24 Jul 2016 21:15:23 +0200
> The kfree() function was called in two cases by the mac_ioctl() function
> during error handling even if the passed variable did not contain a pointer
> for a valid data item.
> Improve this implementation detail by the introduction of another
> jump label.
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>

This is pointless micro-optimisation: kfree(NULL) is perfectly valid
and buff is either malloc'd memory or NULL when it's called.


Julian Calaby

Email: julian.calaby@xxxxxxxxx