Re: [PATCH 2/2] thermal: rockchip: optimize sensor auto accessing period

From: Stephen Barber
Date: Thu Jul 28 2016 - 17:53:52 EST


On Wed, Jul 27, 2016 at 7:10 AM, Caesar Wang <wxt@xxxxxxxxxxxxxx> wrote:
> From: Rocky Hao <rocky.hao@xxxxxxxxxxxxxx>
>
> In less than 10 ms, the temperature of soc will arise 10 degree. 250 ms
> is too big for soc tempeture control. Setting 2.5 ms will speed up
> temperature accessing speed but introduce no more cpu's computing overhead.
> We set AUTO_PERIOD_TIME and TSADCV3_AUTO_PERIOD_HT_TIME the same value,
> because normal temperature update speed is also our consern in IPA.
>
> Signed-off-by: Rocky Hao <rocky.hao@xxxxxxxxxxxxxx>
> Signed-off-by: Caesar Wang <wxt@xxxxxxxxxxxxxx>
> Cc: Zhang Rui <rui.zhang@xxxxxxxxx>
> Cc: Eduardo Valentin <edubezval@xxxxxxxxx>
> Cc: Heiko Stuebner <heiko@xxxxxxxxx>
> Cc: linux-pm@xxxxxxxxxxxxxxx
>
> ---
>
> drivers/thermal/rockchip_thermal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
> index a90423d..1f165c9 100644
> --- a/drivers/thermal/rockchip_thermal.c
> +++ b/drivers/thermal/rockchip_thermal.c
> @@ -213,8 +213,8 @@ struct rockchip_thermal_data {
> #define TSADCV2_HIGHT_TSHUT_DEBOUNCE_COUNT 4
> #define TSADCV2_AUTO_PERIOD_TIME 250 /* 250ms */
> #define TSADCV2_AUTO_PERIOD_HT_TIME 50 /* 50ms */
> -#define TSADCV3_AUTO_PERIOD_TIME 187500 /* 250ms */
> -#define TSADCV3_AUTO_PERIOD_HT_TIME 37500 /* 50ms */
> +#define TSADCV3_AUTO_PERIOD_TIME 1875 /* 2.5ms */
> +#define TSADCV3_AUTO_PERIOD_HT_TIME 1875 /* 2.5ms */
>
> #define TSADCV2_USER_INTER_PD_SOC 0x340 /* 13 clocks */
>
> --
> 1.9.1
>


Tested-by: Stephen Barber <smbarber@xxxxxxxxxxxx>

Steve