Re: [PATCH 2/2] mmc: dw_mmc: remove the deprecated "supports-highspeed" property

From: Jaehoon Chung
Date: Thu Jul 28 2016 - 23:35:08 EST


Hi Shawn,

On 07/29/2016 11:44 AM, Shawn Lin wrote:
> 在 2016/7/28 17:55, Jaehoon Chung 写道:
>> Remvoe the deprecated "supports-highspeed" property.
>> DWMMC controller will not use this property anymore.
>>
>
> We had set up a flag day to remove these deprecated property
> long time agao.
>
> It doesn't *break* old dtb which may(not ?) still boot up new
> kernel code as we just make it suffer from lower speed, then
> I think it's time for them to migrate to the new property anyway.

Thanks for reviewing!

Best Regards,
Jaehoon Chung

>
> So,
>
> Reviewed-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
>
>> Signed-off-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
>> ---
>> drivers/mmc/host/dw_mmc.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
>> index 1b719a6..e9faedd 100644
>> --- a/drivers/mmc/host/dw_mmc.c
>> +++ b/drivers/mmc/host/dw_mmc.c
>> @@ -2890,11 +2890,6 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
>> return ERR_PTR(ret);
>> }
>>
>> - if (of_find_property(np, "supports-highspeed", NULL)) {
>> - dev_info(dev, "supports-highspeed property is deprecated.\n");
>> - pdata->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED;
>> - }
>> -
>> return pdata;
>> }
>>
>>
>
>