Re: [PATCH v2 2/4] drivers: net: cpsw: fix wrong regs access in cpsw_remove

From: Mugunthan V N
Date: Fri Jul 29 2016 - 04:32:15 EST


On Thursday 28 July 2016 11:20 PM, Grygorii Strashko wrote:
> The L3 error will be generated and system will crash during unloading
> of CPSW driver if CPSW is used as module and ethX devices are down.
> This happens because CPSW can be power off by PM runtime now when ethX
> devices are down.
>
> Hence, ensure that CPSW powered up by PM runtime before performing any
> deinitialization actions which require CPSW registers access. In case
> of PM runtime error just leave cpsw_remove() as we can't do anything
> anymore.
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@xxxxxx>

Reviewed-by: Mugunthan V N <mugunthanvnm@xxxxxx>

Regards
Mugunthan V N