Re: [PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its implementation

[Sean Paul]

On Thu, Jul 28, 2016 at 12:18 PM, Wei Yongjun <weiyj.lk@xxxxxxxxx> wrote:
> Use kmemdup rather than duplicating its implementation.
>
> Generated by: scripts/coccinelle/api/memdup.cocci
>
> Signed-off-by: Wei Yongjun <weiyj.lk@xxxxxxxxx>


Thanks for the patch. I'll apply this to -misc once the merge window is closed.

Acked-by: Sean Paul <seanpaul@xxxxxxxxxxxx>


> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> index a46a64c..b779b5f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> @@ -296,12 +296,10 @@ int amdgpu_uvd_suspend(struct amdgpu_device *adev)
>         size = amdgpu_bo_size(adev->uvd.vcpu_bo);
>         ptr = adev->uvd.cpu_addr;
>
> -       adev->uvd.saved_bo = kmalloc(size, GFP_KERNEL);
> +       adev->uvd.saved_bo = kmemdup(ptr, size, GFP_KERNEL);
>         if (!adev->uvd.saved_bo)
>                 return -ENOMEM;
>
> -       memcpy(adev->uvd.saved_bo, ptr, size);
> -
>         return 0;
>  }
>
>
>
>