Re: [PATCH v2] ARM: pxa: fix GPIO double shifts

[Robert Jarzmik]

Joe Perches <joe@xxxxxxxxxxx> writes:

> On Sat, 2016-07-30 at 13:22 +0200, Robert Jarzmik wrote:
...zip...
> $ git grep -w charger_wakeup
> arch/arm/mach-pxa/corgi_pm.c:ÂÂÂ.charger_wakeupÂÂ= corgi_charger_wakeup,
> arch/arm/mach-pxa/sharpsl_pm.c:ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂif (sharpsl_pm.machinfo->charger_wakeup() != 0)
> arch/arm/mach-pxa/sharpsl_pm.c:ÂÂÂÂÂÂÂÂÂif (sharpsl_pm.machinfo->charger_wakeup())
> arch/arm/mach-pxa/sharpsl_pm.h: unsigned long (*charger_wakeup)(void);
> arch/arm/mach-pxa/spitz_pm.c:ÂÂÂ.charger_wakeupÂÂÂ= spitz_charger_wakeup,
...zip...

> It may be better to change the charger_wakeup callback return
> value from unsigned long to bool and modify the other use in
> spitz_pm.cÂ

You're most probably right. I'll do that for v3.

Cheers.

-- 
Robert