Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

From: Lorenzo Colitti
Date: Sun Jul 31 2016 - 21:42:38 EST


On Sat, Jul 30, 2016 at 1:57 AM, John Stultz <john.stultz@xxxxxxxxxx> wrote:
>
> With the patch reverted, and the system working, I see:
>
> # ip rule ls
> 0: from all lookup local
> 10000: from all fwmark 0xc0000/0xd0000 lookup legacy_system
> 13000: from all fwmark 0x10063/0x1ffff lookup local_network
> 13000: from all fwmark 0x10065/0x1ffff lookup wlan0
> 14000: from all oif wlan0 lookup wlan0
> 14000: from all oif wlan0 lookup wlan0
> 15000: from all fwmark 0x0/0x10000 lookup legacy_system
> 16000: from all fwmark 0x0/0x10000 lookup legacy_network
> 17000: from all fwmark 0x0/0x10000 lookup local_network
> 19000: from all fwmark 0x64/0x1ffff lookup wlan0
> 19000: from all fwmark 0x65/0x1ffff lookup wlan0
> 22000: from all fwmark 0x0/0xffff lookup wlan0
> 32000: from all unreachable


This is not correct, you're missing "uidrange 0-0" qualifiers on some
of the rules.

Does the kernel pass the networking unit tests at
https://source.android.com/devices/tech/config/kernel_network_tests.html
? If not, the Android network stack will not work correctly.