Re: [PATCH 3/3] ehci-platform: add the max clock number to 4

[Hans de Goede]

Hi,

On 01-08-16 09:05, Icenowy Zheng wrote:
> 			clocks = <&ccu CLK_A64_BUS_OHCI1>,
> 				 <&ccu CLK_A64_BUS_EHCI1>,
> 				 <&ccu CLK_A64_USB_OHCI0>,
> 				 <&ccu CLK_A64_USB_OHCI1>;
>
> On A64, EHCI requires the matched OHCI to work.

Ah, so just like on the H3 (where this also is needed
and not documented).

> And OHCI1 clock requires OHCI0 clock to work.

Hmm, that one is new, can you double check this ?

Regards,

Hans


> (But from the SoC's user manual we cannot get any infomation
> about the relationship between OHCI1 clock and OHCI0 clock,
> and in the manual OHCI0 clock is called OTG-OHCI)
>
> 01.08.2016, 15:01, "Arnd Bergmann" <arnd@xxxxxxxx>:
> > On Sunday, July 31, 2016 7:25:36 PM CEST Icenowy Zheng wrote:
> > >  Allwinner A64 EHCI requires 4 clocks to be enabled.
> > >
> > >  Signed-off-by: Icenowy Zheng <icenowy@xxxxxxxx>
> >
> > Can you say what those four clocks are?
> >
> > Are you sure that it's not just a case of a clock being
> > incorrectly described in the clk driver, i.e. you reference
> > one clock along with its parent here?
> >
> >         Arnd