Re: [PATCH 5/6] fs: befs: remove in vain variable assignment

From: Luis de Bethencourt
Date: Mon Aug 01 2016 - 10:18:16 EST


On 31/07/16 21:34, Salah Triki wrote:
> There is no need to init res, since it will be overwitten later by
> befs_fblock2brun().
>
> Signed-off-by: Salah Triki <salah.triki@xxxxxxxxx>
> ---
> fs/befs/linuxvfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c
> index 6bc5b40..2b68c81 100644
> --- a/fs/befs/linuxvfs.c
> +++ b/fs/befs/linuxvfs.c
> @@ -120,7 +120,7 @@ befs_get_block(struct inode *inode, sector_t block,
> struct super_block *sb = inode->i_sb;
> befs_data_stream *ds = &BEFS_I(inode)->i_data.ds;
> befs_block_run run = BAD_IADDR;
> - int res = 0;
> + int res;
> ulong disk_off;
>
> befs_debug(sb, "---> befs_get_block() for inode %lu, block %ld",
>

Looks good.

Thanks Salah,
Luis

Acked-by: Luis de Bethencourt <luisbg@xxxxxxxxxxxxxxx>

Pushed to the befs-next branch:
https://github.com/luisbg/linux-befs/tree/befs-next